Use laravel prompts #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are easier to read.
Not yet added upstream, but in the process of getting there. Taken a patch generated from related [PR #88][1] currently at commit a242eebd6eecd193fc036aec5af07d0780135402. [1]: laravel/prompts#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
laravel/prompts seems to improve a lot the user experience compared with raw symfony console.
It is actually built on top of symfony console.
One of the things it lacks is a widget for multi-line input, but there is an open PR at laravel/prompts#88 that provides that.
So, to be able to use that, I also needed to add cweagans/composer-patches.
I added a local diff instead of downloading it dynamically, currently tested with laravel prompts at
v0.1.13.Overall, this adds many dependencies, but the boost in UX is quite nice, so I will take that for now.
If this proves to be hard to maintain, raw symfony console approach will be there.
cc @diegoe